Add ensure_efficient_setup_is_done(::MatrixGroup)
#5469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
topic: groups
release notes: not needed
Member
|
I am confused. I thought that this kind of problem will be magically solved once #4826 is in? |
Member
|
I don't know about magic... (Though finally GAP 4.15.1 is out and we can start switching to it for real) Anyway, I also see no harm in this PR, but let's wait to hear what @ThomasBreuer has to say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses one point in #5348, namely that we should factor out a function that currently creates a nice mono on the gap side, but can be changed to also do other things.
I called this function in the places where we currently do a similar thing manually. More places can be easily added later on.